Unverified Commit f5b78766 authored by Hong Minhee's avatar Hong Minhee
Browse files

Fix fragile _summaries key filtering in getActivitiesByTraceId

Use key structure check instead of string includes to avoid incorrectly
filtering records when traceId/spanId contains "_summaries" substring.

https://github.com/fedify-dev/fedify/pull/502#discussion_r2642993260
parent f6e11e86
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -525,8 +525,8 @@ export class FedifySpanExporter implements SpanExporter {
      const records: TraceActivityRecord[] = [];

      for await (const entry of this.#kv.list!(prefix)) {
        // Skip summary entries
        if (entry.key.includes("_summaries")) continue;
        // Skip summary entries based on key structure
        if (entry.key[this.#keyPrefix.length] === "_summaries") continue;
        records.push(entry.value as TraceActivityRecord);
      }