Commit 71047af1 authored by Fabien O'Carroll's avatar Fabien O'Carroll
Browse files

Support configuring default HTTP signature spec 

no-issue

We're currently running into problems with other servers implementation
of the new RFC 9421 signatures, which breaks interacting with them. This
change allows us to default to the original cavage signatures to
maintain compatibility.
parent 1160e28b

fedify/federation/federation.ts

+3 −0
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ import type { 
  DocumentLoaderFactory,

  GetUserAgentOptions,

} from "../runtime/docloader.ts";

import type { HttpMessageSignaturesSpec } from "../sig/http.ts";

import type { Actor, Recipient } from "../vocab/actor.ts";

import type { Activity, Hashtag, Object } from "../vocab/vocab.ts";

import type {
@@ -678,6 +679,8 @@ export interface FederationOptions<TContextData> { 
   */

  skipSignatureVerification?: boolean;



  defaultHttpMessageSignaturesSpec?: HttpMessageSignaturesSpec;



  /**

   * The retry policy for sending activities to recipients' inboxes.

   * By default, this uses an exponential backoff strategy with a maximum of

fedify/federation/middleware.ts

+6 −0
Original line number Diff line number Diff line
@@ -231,6 +231,7 @@ export class FederationImpl<TContextData> 
  inboxRetryPolicy: RetryPolicy;

  activityTransformers: readonly ActivityTransformer<TContextData>[];

  tracerProvider: TracerProvider;

  defaultHttpMessageSignaturesSpec?: HttpMessageSignaturesSpec;



  constructor(options: FederationOptions<TContextData>) {

    super();
@@ -384,6 +385,7 @@ export class FederationImpl<TContextData> 
            specDeterminer: new KvSpecDeterminer(

              this.kv,

              this.kvPrefixes.httpMessageSignaturesSpec,

              options.defaultHttpMessageSignaturesSpec,

            ),

            tracerProvider: this.tracerProvider,

          }));
@@ -398,6 +400,7 @@ export class FederationImpl<TContextData> 
    this.activityTransformers = options.activityTransformers ??

      getDefaultActivityTransformers<TContextData>();

    this.tracerProvider = options.tracerProvider ?? trace.getTracerProvider();

    this.defaultHttpMessageSignaturesSpec = options.defaultHttpMessageSignaturesSpec;

  }



  _initializeRouter() {
@@ -643,6 +646,7 @@ export class FederationImpl<TContextData> 
        specDeterminer: new KvSpecDeterminer(

          this.kv,

          this.kvPrefixes.httpMessageSignaturesSpec,

          this.defaultHttpMessageSignaturesSpec,

        ),

        tracerProvider: this.tracerProvider,

      });
@@ -1097,6 +1101,7 @@ export class FederationImpl<TContextData> 
            specDeterminer: new KvSpecDeterminer(

              this.kv,

              this.kvPrefixes.httpMessageSignaturesSpec,

              this.defaultHttpMessageSignaturesSpec,

            ),

            tracerProvider: this.tracerProvider,

          }),
@@ -2839,6 +2844,7 @@ export class InboxContextImpl<TContextData> extends ContextImpl<TContextData> 
            specDeterminer: new KvSpecDeterminer(

              this.federation.kv,

              this.federation.kvPrefixes.httpMessageSignaturesSpec,

              this.federation.defaultHttpMessageSignaturesSpec,

            ),

          }),

        );