From 4bc3ebdf79555c92788edb03222a77125e401395 Mon Sep 17 00:00:00 2001 From: Grant Date: Wed, 5 Mar 2025 10:49:17 -0700 Subject: [PATCH 1/2] add tseslint/no-floating-promises & tseslint/no-misued-promises & tseslint/recommended-type-checked --- packages/server/.eslintrc.json | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/server/.eslintrc.json b/packages/server/.eslintrc.json index cf3c95e..c775152 100644 --- a/packages/server/.eslintrc.json +++ b/packages/server/.eslintrc.json @@ -3,7 +3,10 @@ "es2021": true, "node": true }, - "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"], + "extends": [ + "eslint:recommended", + "plugin:@typescript-eslint/recommended-type-checked" + ], "overrides": [ { "env": { @@ -18,7 +21,8 @@ "parser": "@typescript-eslint/parser", "parserOptions": { "ecmaVersion": "latest", - "sourceType": "module" + "sourceType": "module", + "projectService": true }, "plugins": ["@typescript-eslint"], "rules": { @@ -36,6 +40,8 @@ "varsIgnorePattern": "^_", "ignoreRestSiblings": true } - ] + ], + "@typescript-eslint/no-floating-promises": "error", + "@typescript-eslint/no-misused-promises": "error" } } -- GitLab From f8b7b9e77e3675bc7b4d2d7c6492e45218c4cfa6 Mon Sep 17 00:00:00 2001 From: Grant Date: Wed, 5 Mar 2025 10:57:30 -0700 Subject: [PATCH 2/2] add eslint changes to CI --- .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 4f4f234..7888642 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -24,6 +24,7 @@ eslint server: - if: $CI_PIPELINE_SOURCE == "merge_request_event" changes: - packages/server/src/**/* + - packages/server/.eslint* image: node:23-alpine script: - npm i --include=dev -- GitLab